-
Notifications
You must be signed in to change notification settings - Fork 0
Validate for DDBJ Record and updating accession #1405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
maimux2x
commented
Sep 18, 2025
- Rename
- Validate DDBJRecord
1201b67 to
b13677b
Compare
0089619 to
b18ec33
Compare
b18ec33 to
b362b68
Compare
b362b68 to
113bb15
Compare
ursm
reviewed
Oct 3, 2025
|
|
||
| ValidateJob.perform_later @validation | ||
|
|
||
| render status: :created |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| render status: :created | |
| render status: :accepted |
ursm
reviewed
Oct 3, 2025
| def perform(renewal) | ||
| renewal.update! progress: :running, started_at: Time.current | ||
|
|
||
| sleep 3 |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| sleep 3 |
ursm
reviewed
Oct 3, 2025
| obj = validation.objs.without_base.last | ||
|
|
||
| begin | ||
| JSON.parse(obj.file.download) |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| JSON.parse(obj.file.download) | |
| JSON.parse obj.file.download |
ursm
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.